github-actions[bot] commented on PR #22649: URL: https://github.com/apache/datafusion/pull/22649#issuecomment-4585496697
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-common v53.1.0 (current) Built [ 33.331s] (current) Parsing datafusion-common v53.1.0 (current) Parsed [ 0.063s] (current) Building datafusion-common v53.1.0 (baseline) Built [ 32.020s] (baseline) Parsing datafusion-common v53.1.0 (baseline) Parsed [ 0.061s] (baseline) Checking datafusion-common v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.887s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/constructible_struct_adds_field.ron Failed in: field ParquetOptions.max_row_group_bytes in /home/runner/work/datafusion/datafusion/datafusion/common/src/config.rs:843 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 68.313s] datafusion-common Building datafusion-proto v53.1.0 (current) Built [ 56.417s] (current) Parsing datafusion-proto v53.1.0 (current) Parsed [ 0.020s] (current) Building datafusion-proto v53.1.0 (baseline) Built [ 56.198s] (baseline) Parsing datafusion-proto v53.1.0 (baseline) Parsed [ 0.020s] (baseline) Checking datafusion-proto v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.344s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 114.542s] datafusion-proto Building datafusion-proto-common v53.1.0 (current) Built [ 20.400s] (current) Parsing datafusion-proto-common v53.1.0 (current) Parsed [ 0.051s] (current) Building datafusion-proto-common v53.1.0 (baseline) Built [ 20.654s] (baseline) Parsing datafusion-proto-common v53.1.0 (baseline) Parsed [ 0.052s] (baseline) Checking datafusion-proto-common v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 1.379s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/constructible_struct_adds_field.ron Failed in: field ParquetOptions.max_row_group_bytes_opt in /home/runner/work/datafusion/datafusion/datafusion/proto-common/src/generated/prost.rs:904 field ParquetOptions.max_row_group_bytes_opt in /home/runner/work/datafusion/datafusion/datafusion/proto-common/src/generated/prost.rs:904 field ParquetOptions.max_row_group_bytes_opt in /home/runner/work/datafusion/datafusion/datafusion/proto-common/src/generated/prost.rs:904 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 43.843s] datafusion-proto-common Building datafusion-proto-models v53.1.0 (current) Built [ 23.669s] (current) Parsing datafusion-proto-models v53.1.0 (current) Parsed [ 0.129s] (current) Building datafusion-proto-models v53.1.0 (baseline) Built [ 23.470s] (baseline) Parsing datafusion-proto-models v53.1.0 (baseline) Parsed [ 0.131s] (baseline) Checking datafusion-proto-models v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 2.218s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/constructible_struct_adds_field.ron Failed in: field ParquetOptions.max_row_group_bytes_opt in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/datafusion_proto_common.rs:904 field ParquetOptions.max_row_group_bytes_opt in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/datafusion_proto_common.rs:904 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 50.950s] datafusion-proto-models Building datafusion-sqllogictest v53.1.0 (current) Built [ 168.628s] (current) Parsing datafusion-sqllogictest v53.1.0 (current) Parsed [ 0.024s] (current) Building datafusion-sqllogictest v53.1.0 (baseline) Built [ 168.478s] (baseline) Parsing datafusion-sqllogictest v53.1.0 (baseline) Parsed [ 0.026s] (baseline) Checking datafusion-sqllogictest v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.114s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 343.407s] datafusion-sqllogictest ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
