zhuqi-lucas commented on issue #22555: URL: https://github.com/apache/datafusion/issues/22555#issuecomment-4552321182
Good call, that does make the helper the single source of truth for "skip work when children are unchanged" and lets us retire the per-impl variant from #19792. I will update this issue to include the unification step. Probably best split into two PRs to keep review tractable: 1. Move the `PlanProperties` skip logic from #19792 into `with_new_children_if_necessary`, then remove it from the individual `ExecutionPlan` impls. 2. Audit the remaining direct `with_new_children()` call sites and add the clippy lint to enforce the helper going forward. Doing them in this order means callers that haven't switched yet still benefit from the consolidated behavior. Will edit the issue body accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
