andygrove opened a new pull request, #4407:
URL: https://github.com/apache/datafusion-comet/pull/4407

   ## Which issue does this PR close?
   
   N/A
   
   ## Rationale for this change
   
   The iceberg workflow currently uses `paths-ignore` (a deny list) to decide 
when to run. With a deny list, every new file or directory that should not 
trigger iceberg CI must be added explicitly, and it is easy to forget. As a 
result, unrelated changes such as `dev/` scripts, release tooling, and 
golden-file regeneration still trigger the full iceberg test matrix.
   
   `spark_sql_test.yml` already uses a `paths` allow list for the same reason. 
This PR brings the iceberg workflow in line with that approach.
   
   ## What changes are included in this PR?
   
   Switches the `push` and `pull_request` triggers in `iceberg_spark_test.yml` 
from `paths-ignore` to `paths`. The allow list covers the inputs that actually 
affect iceberg tests:
   
   - native library sources and Cargo manifests (excluding HDFS crates)
   - `common` and `spark` main sources and POMs (excluding `GenerateDocs.scala`)
   - `dev/diffs/iceberg/**`, applied by the `setup-iceberg-builder` action
   - root `pom.xml` and `rust-toolchain.toml`
   - the workflow file itself and the composite actions it invokes
   
   Changes to `dev/` scripts, docs, markdown, benchmarks, tests, and 
`spark-integration` no longer trigger iceberg CI.
   
   The allow list mirrors `spark_sql_test.yml`, scoped to `dev/diffs/iceberg` 
and the iceberg-specific workflow and setup action.
   
   ## How are these changes tested?
   
   This is a CI configuration change. The workflow file passes `actionlint`, 
which is enforced by the `validate_workflows.yml` workflow.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to