neilconway opened a new pull request, #22316: URL: https://github.com/apache/datafusion/pull/22316
## Which issue does this PR close? - N/A ## Rationale for this change This PR cleans up and refactors `build_join`, which is used as part of rewriting correlated subqueries. ## What changes are included in this PR? * This routine only needs to handle correlated subqueries now, so simplify the code and add an assert to that effect * Clarify variable names * Improve comments * Hoist a few variables outside of loops, when possible * Use `when`, `lit` and `not` helpers to build the `CASE` expression ## Are these changes tested? Yes, covered by existing tests. ## Are there any user-facing changes? No, no functional changes at all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
