github-actions[bot] commented on PR #21055: URL: https://github.com/apache/datafusion/pull/21055#issuecomment-4390697136
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-ffi v53.1.0 (current) Built [ 53.373s] (current) Parsing datafusion-ffi v53.1.0 (current) Parsed [ 0.050s] (current) Building datafusion-ffi v53.1.0 (baseline) Built [ 53.214s] (baseline) Parsing datafusion-ffi v53.1.0 (baseline) Parsed [ 0.050s] (baseline) Checking datafusion-ffi v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.273s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 108.671s] datafusion-ffi Building datafusion-proto v53.1.0 (current) Built [ 49.507s] (current) Parsing datafusion-proto v53.1.0 (current) Parsed [ 0.126s] (current) Building datafusion-proto v53.1.0 (baseline) Built [ 48.626s] (baseline) Parsing datafusion-proto v53.1.0 (baseline) Parsed [ 0.125s] (baseline) Checking datafusion-proto v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 2.140s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip --- failure trait_method_parameter_count_changed: pub trait method parameter count changed --- Description: A trait method now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/trait_method_parameter_count_changed.ron Failed in: PhysicalExtensionCodec::try_decode now takes 4 instead of 3 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:3705 PhysicalExtensionCodec::try_encode now takes 3 instead of 2 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:3713 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 102.363s] datafusion-proto ``` </details> <!-- semver-check-comment --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
