andygrove commented on code in PR #4111:
URL: https://github.com/apache/datafusion-comet/pull/4111#discussion_r3192454004
##########
spark/src/main/scala/org/apache/comet/serde/strings.scala:
##########
@@ -33,7 +33,7 @@ import
org.apache.comet.serde.QueryPlanSerde.{createBinaryExpr, exprToProtoInter
object CometStringRepeat extends CometExpressionSerde[StringRepeat] {
- override def getCompatibleNotes(): Seq[String] = Seq(
+ override def getIncompatibleReasons(): Seq[String] = Seq(
Review Comment:
Sorry, I have caused confusion here. #4017 was for substring not string
repeat. I do not think that this PR should be touching `CometStringRepeat`? The
PR title is `fix spark ansi sum incompatibility message` and this seems
unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
