tomz commented on PR #4187: URL: https://github.com/apache/datafusion-comet/pull/4187#issuecomment-4380455420
Thanks @andygrove for confirming the repro, and @coderfender for pushing back on the issue link. Pushed fd3fcef addressing both review points: 1. **Dropped the #1615 association.** Removed the issue reference from the inline comment in `evaluate`, the doc-comment on `test_scalar_scalar_returns_scalar`, and the panic message. Kept the concrete TPC-DS q23 BHJ pattern (`0.95 * scalar_subquery > ssales`) as the motivating example, since that's the real-world plan that triggers it. Will also strip `Closes #1615` from the final commit message at merge. 2. **Applied your suggestion on the panic string** — collapsed the broken multi-line literal into a single clean message: `"Scalar x Scalar must return ColumnarValue::Scalar, not Array"`. All 15 unit tests in `wide_decimal_binary_expr` still pass locally, including the new `test_scalar_scalar_returns_scalar` regression guard. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
