Soham-Bhattacharjee-work commented on code in PR #21985:
URL: https://github.com/apache/datafusion/pull/21985#discussion_r3183617022
##########
datafusion/common/src/config.rs:
##########
@@ -3019,36 +3040,54 @@ impl ConfigField for ConfigFileDecryptionProperties {
}
#[cfg(feature = "parquet_encryption")]
-impl From<ConfigFileDecryptionProperties> for FileDecryptionProperties {
- fn from(val: ConfigFileDecryptionProperties) -> Self {
+impl TryFrom<ConfigFileDecryptionProperties> for FileDecryptionProperties {
+ type Error = DataFusionError;
+
+ fn try_from(val: ConfigFileDecryptionProperties) -> Result<Self> {
let mut column_names: Vec<&str> = Vec::new();
let mut column_keys: Vec<Vec<u8>> = Vec::new();
for (col_name, decryption_properties) in
val.column_decryption_properties.iter() {
+ let column_key_as_hex =
hex::decode(&decryption_properties.column_key_as_hex).map_err(|e| {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
