andygrove opened a new pull request, #4208:
URL: https://github.com/apache/datafusion-comet/pull/4208
## Which issue does this PR close?
Part of #4142.
## Rationale for this change
The `spark-4.2` Maven profile (added in #4119) only compiled main sources;
the SQL test diff and CI matrix entry were not yet in place. This PR turns on
the Spark SQL test workflow against Spark 4.2.0-preview4 so we can start
iterating on the failures tracked in #4142.
## What changes are included in this PR?
- Add `dev/diffs/4.2.0-preview4.diff`, seeded from `4.1.1.diff` and
reconciled against `v4.2.0-preview4`. Notable manual reconciliations versus
4.1.1:
- `KeyGroupedPartitioningSuite`: 4.2 already declares `collectAllShuffles`
/ `collectShuffles` as `protected` and returning `Seq[ShuffleExchangeLike]`, so
only the Comet `case` arms and imports are added.
- `WholeStageCodegenSuite`: `BroadcastHashJoinExec` gained a 9th
constructor argument; the `CometColumnarToRowExec` match was rewritten to the
new arity.
- `SQLTestUtils`, `PartitionedTablePerfStatsSuite`,
`WriteDistributionAndOrderingSuite`, `QueryExecutionSuite`, `JoinHintSuite`,
`ParquetRowIndexSuite`, `ParquetTypeWideningSuite`,
`DisableUnnecessaryBucketedScanSuite`: import-only or class-extension
reconciliations.
- Add `{spark-short: '4.2', spark-full: '4.2.0-preview4', java: 17,
scan-impl: 'auto'}` to the `spark_sql_test.yml` matrix.
- Drop the WIP comment from the `spark-4.2` profile in `pom.xml`.
## How are these changes tested?
- Verified `dev/diffs/4.2.0-preview4.diff` re-applies cleanly to a fresh
`v4.2.0-preview4` checkout with no rejects.
- Local `./mvnw -Prelease -Pspark-4.2 -DskipTests -Dmaven.test.skip=true
install` builds clean.
- The new matrix row will exercise the diff in CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
