gstvg commented on code in PR #21323:
URL: https://github.com/apache/datafusion/pull/21323#discussion_r3180260144
##########
datafusion/physical-expr/src/higher_order_function.rs:
##########
@@ -553,9 +566,10 @@ mod tests {
args: HigherOrderFunctionArgs,
) -> Result<ColumnarValue> {
match &args.args[0] {
- ValueOrLambda::Lambda(lambda) => {
- lambda.evaluate(&[&||
Ok(Arc::new(NullArray::new(args.number_rows)))])
- }
+ ValueOrLambda::Lambda(lambda) => lambda.evaluate(
+ &[&|| Ok(Arc::new(NullArray::new(args.number_rows)))],
+ |_| unreachable!(),
Review Comment:
None test that uses that mock capture outer columns that would need to be
spread by that `spread_captures` closure, but it doesn't cost nothing to
implement it, also done at
https://github.com/apache/datafusion/pull/21323/changes/26bc71371532bb67be450314193c500cc354bfb6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
