buraksenn commented on PR #21999: URL: https://github.com/apache/datafusion/pull/21999#issuecomment-4367129546
> LGTM, but there's a deeper issue worth flagging: > > The same bug exists a few lines down (at 840). When the filter keeps some > rows, `byte_size` is just copied from the input as is. So, if a filter cuts 1M > rows down to 1K, we still report the `byte_size` for 1M rows. > > Happy to take this as a quick fix, but do you also want to handle the general case in a follow-up? Thanks @berkaysynnada for the review. It makes sense for me to makes this a follow up I'll handle it soon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
