milenkovicm commented on code in PR #1650:
URL:
https://github.com/apache/datafusion-ballista/pull/1650#discussion_r3178481196
##########
ballista/scheduler/src/state/mod.rs:
##########
@@ -444,17 +444,15 @@ impl<T: 'static + AsLogicalPlan, U: 'static +
AsExecutionPlan> SchedulerState<T,
} else {
None
};
-
+ // let logical_plan_tree =
DisplayableExecutionPlan::new(plan.as_ref());
Review Comment:
nit, can we remove it
##########
ballista/scheduler/src/test_utils.rs:
##########
@@ -973,7 +974,7 @@ pub async fn test_two_aggregations_plan(partition: usize)
-> StaticExecutionGrap
Arc::new(SessionConfig::new_with_ballista()),
&mut planner,
None,
- None,
+ cloned_plan,
Review Comment:
i guess we do not need this paramter
##########
ballista/scheduler/src/state/aqe/mod.rs:
##########
@@ -130,7 +130,7 @@ impl AdaptiveExecutionGraph {
queued_at: u64,
session_config: Arc<SessionConfig>,
logical_plan: Option<String>,
- physical_plan: Option<String>,
+ physical_plan: Arc<dyn ExecutionPlan>,
Review Comment:
is `phisical_plan` duplication of `plan`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
