alamb commented on code in PR #21965:
URL: https://github.com/apache/datafusion/pull/21965#discussion_r3178183591
##########
datafusion/core/src/datasource/listing_table_factory.rs:
##########
@@ -309,6 +309,10 @@ mod tests {
#[tokio::test]
async fn test_create_using_folder_with_compression() {
let dir = tempfile::tempdir().unwrap();
+ // Schema inference now requires at least one file at the location.
+ // The file itself can be 0-byte — it will be filtered out before the
+ // format-specific inference runs, leaving an empty inferred schema.
+ fs::File::create_new(dir.path().join("placeholder.csv.gz")).unwrap();
Review Comment:
what do you think about using `use fs::File` to reduce the redundancy /
follow the existing patterns a bit more?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
