alamb commented on code in PR #21980: URL: https://github.com/apache/datafusion/pull/21980#discussion_r3178117127
########## datafusion/functions/src/strings.rs: ########## @@ -545,13 +545,11 @@ const MAX_BLOCK_SIZE: u32 = 2 * 1024 * 1024; /// Short strings (≤ 12 bytes) are inlined into the view itself; long strings /// are appended into an in-progress data block. When the in-progress block /// fills up it is flushed into `completed` and a new block — double the size -/// of the last, capped at [`MAX_BLOCK_SIZE`] — is started. +/// of the last, capped at [`STRING_VIEW_MAX_BLOCK_SIZE`] — is started. Review Comment: I tried it and I think it will be slower as the StringViewBuilder needs to track Nulls which we know at compile time will never be there -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
