milenkovicm commented on PR #1574: URL: https://github.com/apache/datafusion-ballista/pull/1574#issuecomment-4363252235
thanks @martin-g it looks good, just a few comments Stage view: <img width="1082" height="288" alt="image" src="https://github.com/user-attachments/assets/dd5facae-931b-4258-9c29-14553447ad59"; /> I think this percentiles are going to get messy and too bust very quickly, (input percentiles should not be in ms btw). I'm not sure what would be the best way to declutter them - round values, similar to output rows and elapsed compute adding K,M ... - or move them to task view, similar way spark does (make new tables before task list showing this values) there are quite few values to squeeze in such a small area. Maybe the second approach is better. What do you think ? Task pannel: <img width="1011" height="183" alt="image" src="https://github.com/user-attachments/assets/2fd8e629-3e97-4adb-9dcd-deabe4d91136"; /> - duration does noon say is it seconds, ms ... - do we need all those time columns, some of them have date part other don't. Maybe if we can have launch time and them "wait to be scheduled time" as duration ... two general comments: - not sure if it is possible to have times displayed in local timezone - can we make `tui` feature default -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
