andygrove opened a new pull request, #4178:
URL: https://github.com/apache/datafusion-comet/pull/4178
## Which issue does this PR close?
Part of #242.
## Rationale for this change
Two tests in `InjectRuntimeFilterSuite` are skipped via `IgnoreComet("TODO:
Support SubqueryBroadcastExec in Comet: #242")` in the Spark 3.4.3, 4.0.2, and
4.1.1 diffs. Comet already provides `CometSubqueryBroadcastExec`, and the
corresponding 3.5.8 diff already runs these two tests un-ignored. This PR
aligns the other Spark version diffs with that behavior so we get the
additional coverage.
## What changes are included in this PR?
Regenerates `dev/diffs/3.4.3.diff`, `dev/diffs/4.0.2.diff`, and
`dev/diffs/4.1.1.diff` to drop the `IgnoreComet` annotations on:
- `Runtime bloom filter join: do not add bloom filter if dpp filter exists
on the same column`
- `Runtime bloom filter join: add bloom filter if dpp filter exists on a
different column`
`dev/diffs/3.5.8.diff` already had no `#242` references and is unchanged.
## How are these changes tested?
The two tests were run on Spark 3.5.8 with `ENABLE_COMET=true
ENABLE_COMET_ONHEAP=true` and both passed. The assertions only inspect logical
plans (`BloomFilterAggregate` inside `ScalarSubquery`,
`BloomFilterMightContain` in `Filter` conditions), so they are unaffected by
the choice of physical operator. CI will run the tests for 3.4.3, 4.0.2, and
4.1.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
