andygrove commented on code in PR #4167:
URL: https://github.com/apache/datafusion-comet/pull/4167#discussion_r3174361072
##########
spark/src/main/scala/org/apache/spark/sql/comet/execution/shuffle/CometShuffleExchangeExec.scala:
##########
@@ -318,6 +308,8 @@ object CometShuffleExchangeExec
* Pure: does not tag the node.
*/
private def nativeShuffleFailureReasons(s: ShuffleExchangeExec): Seq[String]
= {
+ val conf = SQLConf.get
+ val strictFloatingPoint =
CometConf.COMET_EXEC_STRICT_FLOATING_POINT.get(conf)
Review Comment:
nit: this is only referenced in the `RangePartition` case I the match
statement, so maybe move it there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
