gstvg commented on PR #21679: URL: https://github.com/apache/datafusion/pull/21679#issuecomment-4358194667
@adriangb I think this decision can be left to the user via the configurable dialect, as today. This PR merely consumes the LambdaFunction from sqlparser-rs AST, which syntax it parses is defined by the configured dialect. Is up to sqlparser to avoid conflicts (see https://github.com/apache/datafusion-sqlparser-rs/pull/2224). The sqllogictests here requires setting the dialect to databricks, for example. I guess what we can do here is: - Add examples to the existing higher-order functions docs with the duckdb syntax with a note that it's dialect dependent. And do the same for json operators as well when they land - Format lambdas with the duckdb syntax, since it's unambiguous and because we don't have access to the configured dialect during formatting - Fix the sql unparser to return a dialect dependent syntax (it currently returns the old syntax for duckdb) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
