Geethapranay1 commented on issue #4131:
URL:
https://github.com/apache/datafusion-comet/issues/4131#issuecomment-4358159132
hi @comphead ,
I looked through the aggregate conversion path, the risky case is the mixed
`{Partial, PartialMerge}` `HashAggregate` generated by distinct aggregates,
where `FIRST`/`LAST` can enter the `PartialMerge` path and depend on
merge/hash-table ordering.
if its still available i'll work on a targeted fallback in
`CometBaseAggregate.doConvert` for `FIRST`/`LAST` only when their aggregate
expression is `PartialMerge`, plus a regression test using the
distinct-aggregate expand pattern. This should preserve the new PartialMerge
support for safe aggregates while fixing the correctness issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
