github-actions[bot] commented on PR #21668:
URL: https://github.com/apache/datafusion/pull/21668#issuecomment-4358093810

   <!-- semver-check-comment -->
   Thank you for opening this pull request!
   
   Reviewer note: 
[cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) 
reported the current version number is not SemVer-compatible with the changes 
in this pull request (compared against the base branch).
   
   <details>
   <summary>Details</summary>
   
   ```
        Cloning origin/main
       Building datafusion-expr v53.1.0 (current)
          Built [  26.574s] (current)
        Parsing datafusion-expr v53.1.0 (current)
         Parsed [   0.077s] (current)
       Building datafusion-expr v53.1.0 (baseline)
          Built [  25.621s] (baseline)
        Parsing datafusion-expr v53.1.0 (baseline)
         Parsed [   0.078s] (baseline)
       Checking datafusion-expr v53.1.0 -> v53.1.0 (no change; assume patch)
        Checked [   1.949s] 222 checks: 222 pass, 30 skip
        Summary no semver update required
       Finished [  56.152s] datafusion-expr
       Building datafusion-optimizer v53.1.0 (current)
          Built [  26.629s] (current)
        Parsing datafusion-optimizer v53.1.0 (current)
         Parsed [   0.030s] (current)
       Building datafusion-optimizer v53.1.0 (baseline)
          Built [  25.500s] (baseline)
        Parsing datafusion-optimizer v53.1.0 (baseline)
         Parsed [   0.030s] (baseline)
       Checking datafusion-optimizer v53.1.0 -> v53.1.0 (no change; assume 
patch)
        Checked [   0.215s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip
   
   --- failure function_missing: pub fn removed or renamed ---
   
   Description:
   A publicly-visible function cannot be imported by its prior path. A `pub 
use` may have been removed, or the function itself may have been renamed or 
removed entirely.
           ref: 
https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
          impl: 
https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/function_missing.ron
   
   Failed in:
     function datafusion_optimizer::push_down_filter::make_filter, previously 
in file 
/home/runner/work/datafusion/datafusion/target/semver-checks/git-origin_main/5b77d0a3aa4aba2901cd4bddaf7b9e32b3147a55/datafusion/optimizer/src/push_down_filter.rs:1382
   
        Summary semver requires new major version: 1 major and 0 minor checks 
failed
       Finished [  53.800s] datafusion-optimizer
       Building datafusion-sqllogictest v53.1.0 (current)
          Built [ 138.981s] (current)
        Parsing datafusion-sqllogictest v53.1.0 (current)
         Parsed [   0.024s] (current)
       Building datafusion-sqllogictest v53.1.0 (baseline)
          Built [ 138.387s] (baseline)
        Parsing datafusion-sqllogictest v53.1.0 (baseline)
         Parsed [   0.025s] (baseline)
       Checking datafusion-sqllogictest v53.1.0 -> v53.1.0 (no change; assume 
patch)
        Checked [   0.108s] 222 checks: 222 pass, 30 skip
        Summary no semver update required
       Finished [ 281.229s] datafusion-sqllogictest
   ```
   
   </details>
   <!-- semver-check-comment -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to