alamb commented on code in PR #21907:
URL: https://github.com/apache/datafusion/pull/21907#discussion_r3170140947
##########
datafusion/datasource-parquet/src/row_group_filter.rs:
##########
@@ -272,6 +274,7 @@ impl RowGroupAccessPlanFilter {
parquet_schema,
row_group_metadatas,
arrow_schema,
+ missing_null_counts_as_zero: true,
Review Comment:
shouldn't this value also be passed down rather than hard coded?
##########
datafusion/datasource-parquet/src/row_group_filter.rs:
##########
@@ -350,6 +376,7 @@ impl RowGroupAccessPlanFilter {
.map(|&i| &groups[i])
.collect::<Vec<_>>(),
arrow_schema,
+ missing_null_counts_as_zero: false,
Review Comment:
why is this always false? Maybe it is worth some comments explaining what is
going on here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
