ariel-miculas commented on code in PR #15591:
URL: https://github.com/apache/datafusion/pull/15591#discussion_r3169360091


##########
datafusion/physical-plan/src/aggregates/row_hash.rs:
##########


Review Comment:
   Could be outside of this PR's scope, but another question I have is why 
isn't there a transition to `ProducingBlocks` as soon as we have a batch ready. 
Instead, all the input is consumed first before producing the first batch 
(assuming there's no group ordering)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to