Omega359 commented on issue #21937: URL: https://github.com/apache/datafusion/issues/21937#issuecomment-4353678551
I'd like to tie this approach into the bench.sh so that one can choose the approach to use, defaulting to criterion as it will have more statistically accurate results. So we will three ways to run benchmarks though all will run through the sql benchmarks (or dfbench for the benchmarks that can't be made into sql based): - BENCH_NAME=tpch cargo bench --bench sql - cargo run --bin benchmark_runner -- run "tpch" - ./bench.sh run tpch Comparing results will use critcmp when run via `cargo bench`/`./bench.sh run tpch` (using criterion) or the existing compare/compare_detail for the non-criterion approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
