asolimando commented on code in PR #21815:
URL: https://github.com/apache/datafusion/pull/21815#discussion_r3166875713
##########
datafusion/physical-plan/src/execution_plan.rs:
##########
@@ -549,7 +550,19 @@ pub trait ExecutionPlan: Any + Debug + DisplayAs + Send +
Sync {
/// If statistics are not available, should return
[`Statistics::new_unknown`]
/// (the default), not an error.
/// If `partition` is `None`, it returns statistics for the entire plan.
- fn partition_statistics(&self, partition: Option<usize>) ->
Result<Arc<Statistics>> {
+ ///
+ /// The [`StatisticsContext`] carries pre-computed child statistics and
+ /// additional context for statistics computation. Use
+ /// [`compute_statistics`] to compute statistics bottom-up, threading
+ /// child statistics through the context automatically.
+ ///
+ /// [`StatisticsContext`]: crate::statistics_context::StatisticsContext
+ /// [`compute_statistics`]: crate::statistics_context::compute_statistics
+ fn partition_statistics(
Review Comment:
Noted and I will make sure to keep both APIs in the future! I will address
this in the next iteration on the code and will resolve the discussion at that
point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
