github-actions[bot] commented on PR #21193: URL: https://github.com/apache/datafusion/pull/21193#issuecomment-4350437763
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning origin/main Building datafusion-substrait v53.1.0 (current) Built [ 314.198s] (current) Parsing datafusion-substrait v53.1.0 (current) Parsed [ 0.018s] (current) Building datafusion-substrait v53.1.0 (baseline) Built [ 317.177s] (baseline) Parsing datafusion-substrait v53.1.0 (baseline) Parsed [ 0.018s] (baseline) Checking datafusion-substrait v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.283s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip --- failure trait_method_added: pub trait method added --- Description: A non-sealed public trait added a new method without a default implementation, which breaks downstream implementations of the trait ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-item-no-default impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/trait_method_added.ron Failed in: trait method datafusion_substrait::logical_plan::consumer::SubstraitConsumer::with_lambda_parameters in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:535 trait method datafusion_substrait::logical_plan::consumer::SubstraitConsumer::lambda_variable in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:545 trait method datafusion_substrait::logical_plan::producer::SubstraitProducer::push_lambda_parameters in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/producer/substrait_producer.rs:463 trait method datafusion_substrait::logical_plan::producer::SubstraitProducer::pop_lambda_parameters in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/producer/substrait_producer.rs:471 trait method datafusion_substrait::logical_plan::producer::SubstraitProducer::lambda_variable in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/producer/substrait_producer.rs:477 trait method datafusion_substrait::logical_plan::producer::SubstraitProducer::lambda_parameter_type in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/producer/substrait_producer.rs:482 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 635.346s] datafusion-substrait ``` </details> <!-- semver-check-comment --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
