adriangb commented on PR #21949: URL: https://github.com/apache/datafusion/pull/21949#issuecomment-4349735114
**Note on the `Comment on pull request` CI failure** The failing check is an Apache/datafusion CI infrastructure limitation: the workflow posts cargo-semver-checks findings as a PR comment via bash, and with the volume of public-API path changes in this refactor, the comment body exceeds the OS `Argument list too long` limit (`/usr/bin/bash ... Argument list too long`). The underlying `Check semver` step itself **passes** — semver-checks runs to completion and emits its report; only the comment-posting step fails. Reviewers can read the full semver findings in the [Check semver job log](https://github.com/apache/datafusion/actions/runs/25147371106). The bulk of the findings are paths like `datafusion_proto::generated::datafusion::JoinType` that previously resolved through embedded duplicate types (the `datafusion_proto_common.rs` file embedded into `mod datafusion`) and now resolve via re-exports from `datafusion-proto-models`. I added `pub use super::datafusion_proto_common::*;` inside `proto-models::generated::datafusion` to preserve as many of these as possible (commit e81d77fb4); cargo-semver-checks still flags some because it doesn't always follow cross-crate re-exports. If reviewers prefer a different approach for the back-compat surface, happy to adjust. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
