xudong963 commented on code in PR #21637:
URL: https://github.com/apache/datafusion/pull/21637#discussion_r3165227615
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -3773,11 +3773,11 @@ impl PartialOrd for Aggregate {
/// Returns 0 when no grouping set is duplicated.
fn max_grouping_set_duplicate_ordinal(group_expr: &[Expr]) -> usize {
if let Some(Expr::GroupingSet(GroupingSet::GroupingSets(sets))) =
group_expr.first() {
- let mut counts: HashMap<&[Expr], usize> = HashMap::new();
- for set in sets {
- *counts.entry(set).or_insert(0) += 1;
- }
- counts.into_values().max().unwrap_or(0).saturating_sub(1)
+ sets.iter()
Review Comment:
yes, I reverted the changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
