andygrove opened a new pull request, #4152:
URL: https://github.com/apache/datafusion-comet/pull/4152
## Summary
- Add support for `parse_url`, `url_encode`, and `url_decode` Spark
expressions using native implementations from the `datafusion-spark` crate
- `parse_url` maps to `parse_url`/`try_parse_url` based on ANSI mode
(`failOnError`), supporting both 2-arg and 3-arg forms
- `url_encode`/`url_decode` are `RuntimeReplaceable` in Spark (rewritten to
`StaticInvoke(UrlCodec, "encode"/"decode")`) — added handlers in
`CometStaticInvoke` to intercept and route to native functions
- Includes SQL file tests for all three functions covering column refs,
literals, NULLs, empty strings, special characters, multibyte UTF-8, and
roundtrip encode/decode
Partial fix for #4150
## Test plan
- [ ] New SQL file tests in
`spark/src/test/resources/sql-tests/expressions/url/`
- `parse_url.sql` — HOST, PATH, QUERY, REF, PROTOCOL, FILE, AUTHORITY,
USERINFO extraction; 3-arg QUERY key extraction; NULL handling
- `url_encode.sql` — special characters, multibyte UTF-8, empty string,
NULL
- `url_decode.sql` — percent-encoded strings, plus-as-space, roundtrip,
multibyte UTF-8, NULL
- [ ] Rust compiles (`cargo check` passes)
- [ ] Scala compiles with no errors (`mvn compile` passes)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
