adriangb commented on code in PR #21806:
URL: https://github.com/apache/datafusion/pull/21806#discussion_r3164650235
##########
datafusion/physical-expr/src/expressions/case.rs:
##########
@@ -814,17 +814,13 @@ impl CaseBody {
}
}?;
- // `true_count` ignores `true` values where the validity bit is
not set, so there's
- // no need to call `prep_null_mask_filter`.
Review Comment:
Worth keeping this comment?
##########
datafusion/functions-nested/src/replace.rs:
##########
@@ -347,7 +347,7 @@ fn general_replace<O: OffsetSizeTrait>(
let mut counter = 0;
// All elements are false, no need to replace, just copy original data
- if eq_array.false_count() == eq_array.len() {
+ if !eq_array.has_true() {
Review Comment:
We used to not take this path if there were any nulls but now we do. The
implementation seems to allow this so it's okay, but I wanted to flag it for
you to confirm.
##########
datafusion/physical-expr/src/expressions/case.rs:
##########
@@ -903,17 +899,13 @@ impl CaseBody {
internal_datafusion_err!("WHEN expression did not return a
BooleanArray")
})?;
- // `true_count` ignores `true` values where the validity bit is
not set, so there's
- // no need to call `prep_null_mask_filter`.
Review Comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
