adriangb commented on code in PR #21929:
URL: https://github.com/apache/datafusion/pull/21929#discussion_r3163306149
##########
.github/workflows/rust.yml:
##########
@@ -604,7 +601,6 @@ jobs:
rust-version: stable
Review Comment:
This seems sus
##########
datafusion/proto-models/LICENSE.txt:
##########
@@ -0,0 +1,212 @@
+
Review Comment:
We could split this into 2 PRs or stack the commits so that the diff is not
polluted by 800 lines of boilerplate
##########
datafusion/proto/src/logical_plan/file_formats.rs:
##########
@@ -79,8 +80,8 @@ impl CsvOptionsProto {
}
}
-impl From<&CsvOptionsProto> for CsvOptions {
- fn from(proto: &CsvOptionsProto) -> Self {
+impl FromProto<&CsvOptionsProto> for CsvOptions {
Review Comment:
I want to double check this change. It doesn't seem obviously linked to the
other changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
