asubiotto commented on code in PR #21924:
URL: https://github.com/apache/datafusion/pull/21924#discussion_r3162351726
##########
datafusion/expr-common/src/type_coercion/binary.rs:
##########
@@ -1767,7 +1767,7 @@ pub fn like_coercion(lhs_type: &DataType, rhs_type:
&DataType) -> Option<DataTyp
string_coercion(lhs_type, rhs_type)
.or_else(|| binary_to_string_coercion(lhs_type, rhs_type))
.or_else(|| dictionary_coercion(lhs_type, rhs_type, false,
string_coercion))
Review Comment:
I think this should also be `like_coercion`. Dictionary probably suffers
from the same issue but it's a little more rare to find a dict of a complex
type (e.g. Dict<Struct>). Happy to fix it, wasn't sure whether to keep this PR
ree only.
##########
datafusion/expr-common/src/type_coercion/binary.rs:
##########
@@ -1767,7 +1767,7 @@ pub fn like_coercion(lhs_type: &DataType, rhs_type:
&DataType) -> Option<DataTyp
string_coercion(lhs_type, rhs_type)
.or_else(|| binary_to_string_coercion(lhs_type, rhs_type))
.or_else(|| dictionary_coercion(lhs_type, rhs_type, false,
string_coercion))
Review Comment:
I think this should also be `like_coercion`. Dictionary probably suffers
from the same issue but it's a little more rare to find a dict of a complex
type (e.g. `Dict<Struct>`). Happy to fix it, wasn't sure whether to keep this
PR ree only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
