kumarUjjawal commented on PR #21926: URL: https://github.com/apache/datafusion/pull/21926#issuecomment-4345216046
@Jefffrey Can you take a look whenever you get the chance, my previous attempt was not ideal, though this also has more scope than I was going for, I tried splitting it but the main reason I kept these pieces together is that the decimal state model is shared across the normal, grouped, window/retract, distinct, and partial/final path and I couldn't really make it look good than reapeting things. If you have any ideas how I can split it meaningfully, I would re-work this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
