ologlogn commented on PR #21903: URL: https://github.com/apache/datafusion/pull/21903#issuecomment-4343868799
PR #21895 (currently open) adds `array_filter` and extracts shared HOF utilities into `lambda_utils.rs`. If that merges first, a few things here could be simplified: - `coerce_value_types` body → `crate::lambda_utils::coerce_single_list_arg(self.name(), arg_types)` - `lambda_parameters` body → `crate::lambda_utils::single_list_lambda_parameters(self.name(), fields)` - inline `take_function_args` + destructure in `invoke_with_args` → `crate::lambda_utils::value_lambda_pair(self.name(), &args.args)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
