2010YOUY01 commented on code in PR #21904:
URL: https://github.com/apache/datafusion/pull/21904#discussion_r3159070871
##########
datafusion/functions/src/unicode/substrindex.rs:
##########
@@ -272,7 +272,7 @@ where
O: OffsetSizeTrait,
{
let num_rows = string_array.len();
- // Output is null IFF any input is null.
+ // Output is null if any input is null.
Review Comment:
```suggestion
// Output is null if and only if any input is null.
```
I think here it's using `IFF` explicitly to imply 'if and only if', and it's
precise for this UDF (not found won't return null). But we should avoid those
shorthands anyway.
Other 'iff's seem to be either typo or misuse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
