2010YOUY01 commented on code in PR #21898: URL: https://github.com/apache/datafusion/pull/21898#discussion_r3158452030
########## datafusion/sqllogictest/test_files/explain_analyze.slt: ########## @@ -24,7 +24,7 @@ EXPLAIN ANALYZE SELECT * FROM generate_series(100); Plan with Metrics LazyMemoryExec: partitions=1, batch_generators=[generate_series: start=0, end=100, batch_size=8192], metrics=[output_rows=101, elapsed_compute=<slt:ignore>, output_bytes=<slt:ignore>] # -------------------------------------------- -# Test parquet-only output_rows_skew metric +# Test parquet-only output_rows_skew metric (WITH ORDER(x) → preserve_order scan) # -------------------------------------------- statement ok Review Comment: ```suggestion # Parquet supports dynamic work scheduling by default; per-partition data # sources might steal work from siblings, making row counts per partition # non-deterministic. Forcing `WITH ORDER` disables this behavior. statement ok ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
