discord9 opened a new pull request, #21908: URL: https://github.com/apache/datafusion/pull/21908
## Which issue does this PR close? ## Rationale for this change as title, forbid lossy cast for now(maybe could add them back as between expr later?) like cast(ts_ns to ms) == literal_ms, which is not equal to ts_ns == literal_ns since like cast(1ns)=0ms but 1ns!=0ns ## What changes are included in this PR? simply forbid lossy cast for now in ExprSimpilfy ## Are these changes tested? unit tests are added <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? this is a fix, so I guess previous incorrect behavior will be change? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
