xudong963 opened a new pull request, #21905: URL: https://github.com/apache/datafusion/pull/21905
## Which issue does this PR close? Related to #21637. ## Rationale for this change The benchmark binaries currently reject enabling both `snmalloc` and `mimalloc`. However, workspace-wide checks such as `cargo clippy --all-targets --all-features` enable both feature flags, which makes these binaries fail before clippy can run. ## What changes are included in this PR? This PR removes the explicit compile error from the benchmark binaries and makes allocator selection deterministic: `snmalloc` is used when enabled, otherwise `mimalloc` is used when enabled. ## Are these changes tested? Ran: - `cargo fmt --all` - `cargo fmt --all -- --check` - `git diff --check` I also attempted `cargo clippy --all-targets --all-features -- -D warnings`, but the local run failed due to the machine running out of disk space (`No space left on device`) while compiling dependencies, before reaching clippy diagnostics for this change. ## Are there any user-facing changes? No. This only affects benchmark binary feature combinations used by development checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
