huymq1710 commented on PR #21886: URL: https://github.com/apache/datafusion/pull/21886#issuecomment-4340176804
Thanks for the reviews and running the benchmarks Performance appears neutral (1.00x - 1.03x), so the benefit is primarily the state reduction and memory efficiency mentioned by @Dandandan My goal is to learn DataFusion's internals, so I'm happy to either merge or close it if you'd prefer to keep the current implementation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
