andygrove opened a new pull request, #4135:
URL: https://github.com/apache/datafusion-comet/pull/4135

   ## Which issue does this PR close?
   
   Closes #.
   
   ## Rationale for this change
   
   Several CI workflows currently use `paths-ignore` to skip runs when only 
documentation or changelog files are touched, but the only `dev/` entry in the 
ignore list is `dev/changelog/*.md`. Other files under `dev/` (release scripts, 
copyright notices, checkstyle config, Cargo config, helper shell scripts, etc.) 
do not affect build or test outcomes for these workflows, yet still trigger 
full CI runs.
   
   The exception is `dev/diffs/`, which contains the Spark patches consumed by 
the Iceberg and Spark SQL test workflows. Changes there must keep triggering 
those two workflows.
   
   ## What changes are included in this PR?
   
   Replace the narrow `dev/changelog/*.md` ignore entry with `dev/**` in:
   
   - `.github/workflows/iceberg_spark_test.yml` (with `!dev/diffs/**` to keep 
diff edits triggering)
   - `.github/workflows/spark_sql_test.yml` (with `!dev/diffs/**`)
   - `.github/workflows/pr_build_linux.yml`
   - `.github/workflows/pr_build_macos.yml`
   - `.github/workflows/miri.yml`
   
   The `pr_build_*` and `miri` workflows do not consume `dev/diffs/`, so the 
negation is omitted there.
   
   ## How are these changes tested?
   
   Workflow-only change. The path filters take effect on the next push/PR; a 
follow-up commit touching only a non-diffs `dev/` file (for example 
`dev/copyright`) should not trigger these workflows, while a change under 
`dev/diffs/` should still trigger the iceberg and spark-sql workflows.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to