adriangb commented on code in PR #21830:
URL: https://github.com/apache/datafusion/pull/21830#discussion_r3156770168
##########
datafusion/physical-plan/src/joins/hash_join/partitioned_hash_eval.rs:
##########
@@ -201,6 +202,127 @@ impl PhysicalExpr for HashExpr {
}
}
+/// Physical expression that computes the output partition id for hash
repartitioning.
+///
+/// This expression must stay aligned with `RepartitionExec` because
partitioned
+/// dynamic filters use it to route probe rows to the build-side hash table for
+/// the matching hash partition.
+pub(crate) struct HashPartitionExpr {
Review Comment:
don't we unfortunately need to make this public so it can be serialized,
etc.? Unless we go down the path of
https://github.com/apache/datafusion/issues/21835
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]