coderfender commented on code in PR #4068:
URL: https://github.com/apache/datafusion-comet/pull/4068#discussion_r3152090536


##########
spark/src/main/java/org/apache/spark/sql/comet/execution/shuffle/SpillWriter.java:
##########
@@ -202,6 +214,10 @@ protected long doSpilling(
 
     long written = results[0];
     checksum = results[1];
+    // results[2] = encode + compression time in nanoseconds (measured by 
native code)
+    if (encodeNanosAcc != null) {

Review Comment:
   Curious why we couldn't start from 0 and remove the null check ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to