wForget commented on code in PR #4097:
URL: https://github.com/apache/datafusion-comet/pull/4097#discussion_r3151233479
##########
pom.xml:
##########
@@ -682,6 +682,30 @@ under the License.
</properties>
</profile>
+ <profile>
+ <!-- WIP: Spark 4.1 support, with its own shim sources for 4.1-specific
APIs -->
+ <id>spark-4.1</id>
+ <properties>
+ <!-- Spark 4.1.1 is compiled against Scala 2.13.17 and emits calls
into stdlib methods
+ added in that release (e.g.
MurmurHash3$.caseClassHash$default$2()). Comet must
+ match to avoid runtime NoSuchMethodError. Note:
semanticdb-scalac_2.13.17 is not
+ yet published, so the -Psemanticdb / scalafix lint job is skipped
for spark-4.1. -->
+ <scala.version>2.13.17</scala.version>
Review Comment:
Will there be any issues upgrading the scala version in the `scala-2.13`
profile to `2.13.17`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
