alamb opened a new pull request, #21879: URL: https://github.com/apache/datafusion/pull/21879
## Which issue does this PR close? - Related to https://github.com/apache/datafusion/pull/21651 from @Dandandan ## Rationale for this change While reviewing https://github.com/apache/datafusion/pull/21651 I found that `sin(x)` is hard coded to always return `[-1, 1]` as its bounds regardless of its input: https://github.com/apache/datafusion/blob/5901df58b21b8b4e36011744e7ddc17bcb6a37b3/datafusion/functions/src/math/bounds.rs#L27-L32 This is not clear from the docs and https://github.com/apache/datafusion/pull/21651 was assuming something different ## What changes are included in this PR? 1. Update the documentation to reflect the current state of the code (the bound are not exact) ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
