andygrove commented on code in PR #4105:
URL: https://github.com/apache/datafusion-comet/pull/4105#discussion_r3148425847
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -166,6 +166,7 @@ object QueryPlanSerde extends Logging with CometExprShim
with CometTypeShim {
classOf[GetJsonObject] -> CometGetJsonObject,
classOf[InitCap] -> CometInitCap,
classOf[Length] -> CometLength,
+ classOf[Levenshtein] -> CometScalarFunction("levenshtein"),
Review Comment:
Spark 4 lets levenshtein accept `StringTypeWithCollation`. With a
non-default collation like `utf8_lcase`, Spark expects collation-aware
comparison. The PR does no collation check. Could you implement
`getSupportLevel` for this expression so it falls back for unsupported
collations in Spark 4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
