sandugood commented on code in PR #1594:
URL:
https://github.com/apache/datafusion-ballista/pull/1594#discussion_r3147365201
##########
ballista/scheduler/src/state/aqe/planner.rs:
##########
@@ -445,13 +444,6 @@ impl AdaptivePlanner {
let default_optimizers = PhysicalOptimizer::new();
physical_optimizers.extend(default_optimizers.rules.iter().cloned());
physical_optimizers.push(Arc::new(PropagateEmptyExecRule::default()));
- // this rule is not required anymore
- //
physical_optimizers.push(Arc::new(EliminateRoundRobbinRule::default()));
-
physical_optimizers.push(Arc::new(EliminateCooperativeExecRule::default()));
- // we should remove it at the later stage
- // this is just temporary to detect possible duplicate
- // execs
- physical_optimizers.push(Arc::new(WarnOnDuplicateExecRule::default()));
Review Comment:
Sure, kept this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
