Adez017 commented on code in PR #21873:
URL: https://github.com/apache/datafusion/pull/21873#discussion_r3147261203
##########
datafusion/proto/src/physical_plan/mod.rs:
##########
@@ -681,16 +681,17 @@ impl protobuf::PhysicalPlanNode {
})?;
let filter_selectivity = filter.default_filter_selectivity.try_into();
- let projection = if !filter.projection.is_empty() {
- Some(
- filter
- .projection
- .iter()
- .map(|i| *i as usize)
- .collect::<Vec<_>>(),
- )
+ // After deserializing, check if it equals the full range
+ let num_fields = schema.fields().len();
+ let full_projection: Vec<usize> = (0..num_fields).collect();
Review Comment:
Thanks for the feedback @askalt !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
