Geethapranay1 commented on issue #21780: URL: https://github.com/apache/datafusion/issues/21780#issuecomment-4326646912
Hi @zhuqi-lucas I'd like to take this. I've reviewed pr #21580 and understand the issue. The main problem is DynamicFilterPhysicalExpr.fetch copies the value from SortExec.fetch at creation time. If with_fetch() updates the value later, the filter's copy goes stale. i would like to use `Arc<AtomicUsize>` so the filter always reads the current fetch value, not a copy. i plan to: - replace fetch: `Option<usize>` with `Arc<AtomicUsize>` in DynamicFilterPhysicalExpr - pass a shared reference from instead of copying - test that updates are visible (stats init + cumulative pruning) - run TopK tests to verify no regressions is that what u are expecting? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
