askalt opened a new issue, #21871:
URL: https://github.com/apache/datafusion/issues/21871

   Consider the following places in the physical plan serde code.
   
   serialization:
   
   
https://github.com/apache/datafusion/blob/1897c281139b7b33875f36e18bd2dd5565dcaee1/datafusion/proto/src/physical_plan/mod.rs#L2353-L2354
   
   deserealization:
   
   
https://github.com/apache/datafusion/blob/1897c281139b7b33875f36e18bd2dd5565dcaee1/datafusion/proto/src/physical_plan/mod.rs#L684-L694
   
   If we consider `FilterExec` with an empty projection (`vec![]`), then it is 
serialized as an empty vector. Then the deserialization code makes a 
`FilterExec` with `None` as projection, which semantics is a full projection. 
The problem is that `None` and `Some(vec![])` have the same proto 
representation.
   
   The simplest solution:
   
   1) Make `(0..fields.len()).collect()`  vec when `None` projection is 
serialized.
   2) Make `None` if this vec is met in the deserialization code.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to