1fanwang commented on PR #21870: URL: https://github.com/apache/datafusion/pull/21870#issuecomment-4326229516
@asolimando Possible — a canonicalization pass at simplifier entry would let downstream rules use plain `==` and skip the per-leaf `NormalizeEq` dispatch. The reason I went with the leaf-level shape is that #8780 specifically disabled canonicalization on `LogicalPlan::Join` (the exact path #14943 hits), so a global pre-pass would either need to re-enable it there or thread carefully around it — bigger surface than what @alamb sketched in the issue thread. If you and @alamb think the bigger refactor is the right shape, I'll redo it; otherwise this minimal version implements his suggestion directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
