kumarUjjawal commented on code in PR #20793:
URL: https://github.com/apache/datafusion/pull/20793#discussion_r3145024622
##########
datafusion/sqllogictest/test_files/scalar.slt:
##########
@@ -522,9 +524,11 @@ select
----
1 -2 123 -123
Review Comment:
We should also add the original test from the issue
`floor(arrow_cast('-999.9', 'Decimal128(4,1)'))`
##########
datafusion/sqllogictest/test_files/scalar.slt:
##########
@@ -522,9 +524,11 @@ select
----
1 -2 123 -123
-# floor overflow with limited precision
-query error Decimal overflow while applying floor
+# floor with limited precision (no overflow since scale reduces to 0)
+query R
select floor(arrow_cast(-9.23,'Decimal128(3,2)'));
Review Comment:
Having the overflow check for `Decimal32`, `Decimal64` and `Decimal256`
would be great
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
